Implementation of python setup.py extractor. #365
+578
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvarga
reviewed
Feb 5, 2025
|
|
||
| // defaultMaxFileSizeBytes is the maximum file size an extractor will unmarshal. | ||
| // If Extract gets a bigger file, it will return an error. | ||
| defaultMaxFileSizeBytes = 100 * units.MiB |
There was a problem hiding this comment.
I don't think these files typically get this big - 30M should be enough
| name=_pkg_name, | ||
| install_requires=[ | ||
| '%s==6.5.1', | ||
| 'xmlschema=={}', |
There was a problem hiding this comment.
Does this mean "any version"?
In that case we should store this package as version 0
| '%s==6.5.1', | ||
| 'xmlschema=={}', | ||
| 'requests==2.25.1', | ||
| 'lxml>=4.6.2', |
There was a problem hiding this comment.
We should also store versions if the comparator is >=. In that case we can store the lowest possible version, i.e. 4.6.2 in this case
| 'requests==2.25.1', | ||
| 'lxml>=4.6.2', | ||
| 'Jinja2==2.11.3;python_version<"3.6"', | ||
| # 'sslyze>=4.0.4', # todo |
There was a problem hiding this comment.
Let's make sure comments are skipped, i.e. if this was # 'sslyze==4.0.4' it should not be added to the Inventory.
| @@ -0,0 +1,27 @@ | |||
| import re | |||
There was a problem hiding this comment.
Can you add 1 or 2 more sample setup.py files to the testdata to make sure we cover common cases?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the python setup.py extractor.
Implemented: